Resolved a regression of template_methods working when overloaded by library steps
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
fixes #291
a bug was introduced by #283 that caused a regression in template methods working as expected.
Description
PR #283 introduced a bug where the
TemplatePrimitiveCollectorwas not being persisted after eachTemplatePrimitiveInjector.This resulted in
TemplateMethodInjectornot being able to access theTemplatePrimitivesthat had been created byLibraryStepInjector.The fix was to update the
TemplatePrimitiveInjector.invoke$method so that the updatedTemplatePrimitiveCollectoris persisted on theWorkflowRunafter each injector is invoked.How Has This Been Tested
reproduced the bug both manually and in unit tests.
confirmed that the change fixes both.
Types of Changes
Checklist